Add check name in results #376
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting for feedback whether this approach is good or not. |
|
@ernilambar I like the idea of optionally supporting the inclusion of the check identifier. That said, I think we'll need to carefully think about how to implement that change. Preferably, this should be handled in a central place, without having to define the check identifiers as both array keys and in each class. |
|
@felixarntz May be this approach is better. Please review it. #380 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Checkis assumed to have a name. Soget_name()has been added tointerface Check.checkhas been added tofinal class Check_Result.includes/Traits/Amend_Check_Result.php- Methods are updated to accomodate newly addedcheckfield.Late_Escaping_Check.php:get_name()method is implemented. Eg:Output:
